Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Wed, 25 Jan 2017 05:14:26 +0000 (UTC)
From: "Rakesh R (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13037124.1485195993000.196047.1485321266642@Atlassian.JIRA>
In-Reply-To: <JIRA.13037124.1485195993000@Atlassian.JIRA>
References: <JIRA.13037124.1485195993000@Atlassian.JIRA> <JIRA.13037124.1485195993491@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2672) Remove CHANGE.txt
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Jan 2017 05:14:33 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837207#comment-15837207 ] 

Rakesh R commented on ZOOKEEPER-2672:
-------------------------------------

Thanks [~hanm] for reporting this.
Now, we have github repo in place and I'm +1 on removing CHANGE.txt file. Just a thought, should we update any of the ZooKeeper docs/cwiki page conveying that {{github revision log}} can be used for patch attribution etc. ?

> Remove CHANGE.txt
> -----------------
>
>                 Key: ZOOKEEPER-2672
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2672
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>
> The CHANGE.txt is already not the source of truth of what's changed after we migrating to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually is cumbersome and error prone.
> The consensus is we would rely on source control revision logs instead of CHANGE.txt moving forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for more details.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)