Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Mon, 16 Jan 2017 11:45:26 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13003857.1473428148000.14771.1484567126512@Atlassian.JIRA>
In-Reply-To: <JIRA.13003857.1473428148000@Atlassian.JIRA>
References: <JIRA.13003857.1473428148000@Atlassian.JIRA> <JIRA.13003857.1473428148980@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt
 git repo
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 16 Jan 2017 11:45:32 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823820#comment-15823820 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
-------------------------------------------

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96212537
  
    --- Diff: src/lastRevision.sh ---
    @@ -16,6 +16,6 @@
     
     # Find the current revision, store it in a file
     FILE=$1
    -LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
    +LASTREV=`git rev-parse HEAD | cut -c1-8`
    --- End diff --
    
    Thanks @eribeiro for the patch. Any specific reason to use only the first 8 characters of the git SHA-1. Will this be helpful in analyzing whether a particular fix included in the release?
    
    How about keeping the complete SHA-1?


> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
>                 Key: ZOOKEEPER-2573
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Arshad Mohammad
>            Assignee: Edward Ribeiro
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo revision which is of type int
> But after migrating to git repo the git repo's revision(commit 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be modified. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)