Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6CDD9200C07 for ; Sat, 7 Jan 2017 22:55:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6B729160B27; Sat, 7 Jan 2017 21:55:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6640160B3C for ; Sat, 7 Jan 2017 22:54:59 +0100 (CET) Received: (qmail 36838 invoked by uid 500); 7 Jan 2017 21:54:58 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 36808 invoked by uid 99); 7 Jan 2017 21:54:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jan 2017 21:54:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7B7F02C1F56 for ; Sat, 7 Jan 2017 21:54:58 +0000 (UTC) Date: Sat, 7 Jan 2017 21:54:58 +0000 (UTC) From: "Jordan Zimmerman (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2368) Client watches are not disconnected on close MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 07 Jan 2017 21:55:00 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15808215#comment-15808215 ] Jordan Zimmerman commented on ZOOKEEPER-2368: --------------------------------------------- FYI - I did some quick tests with Curator and this patch works fine. > Client watches are not disconnected on close > -------------------------------------------- > > Key: ZOOKEEPER-2368 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2368 > Project: ZooKeeper > Issue Type: Improvement > Affects Versions: 3.4.0, 3.5.0 > Reporter: Timothy Ward > Assignee: Timothy Ward > Fix For: 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2368.patch > > > If I have a ZooKeeper client connected to an ensemble then obviously I can register watches. > If the client is disconnected (for example by a failing ensemble member) then I get a disconnection event for all of my watches. If, on the other hand, my client is closed then I *do not* get a disconnection event. This asymmetry makes it really hard to clear up properly when using the asynchronous API, as there is no way to "fail" data reads/updates when the client is closed. > I believe that the correct behaviour should be for all watchers to receive a disconnection event when the client is closed. The watchers can then respond as appropriate, and can differentiate between a "server disconnect" and a "client disconnect" by checking the ZooKeeper#getState() method. > This would not be a breaking behaviour change as Watchers are already required to handle disconnection events. -- This message was sent by Atlassian JIRA (v6.3.4#6332)