Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: fpj <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-157-zookeeper@git.apache.org>
In-Reply-To: <git-pr-157-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #157: ZOOKEEPER-2678: Discovery and Sync can take a v...
Content-Type: text/plain
Message-Id: <20170128191535.50C68DFCDD@git1-us-west.apache.org>
Date: Sat, 28 Jan 2017 19:15:35 +0000 (UTC)
archived-at: Sat, 28 Jan 2017 19:15:37 -0000

Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/157#discussion_r98336253
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -364,10 +367,12 @@ else if (qp.getType() == Leader.SNAP) {
                 
                 long lastQueued = 0;
     
    -            // in V1.0 we take a snapshot when we get the NEWLEADER message, but in pre V1.0
    +            // in Zab V1.0 (ZK 3.4+) we might take a snapshot when we get the NEWLEADER message, but in pre V1.0
                 // we take the snapshot at the UPDATE, since V1.0 also gets the UPDATE (after the NEWLEADER)
                 // we need to make sure that we don't take the snapshot twice.
    -            boolean snapshotTaken = false;
    +            boolean isPreZAB1_0 = true;
    +            //If we are not going to take the snapshot be sure the edits are not applied in memory
    +            boolean writeToEditLog = !snapshotNeeded;
    --- End diff --
    
    The changes here are using `edit` to refer to `txns`. I'd rather use `txn` to be consistent across the project. Specifically here, you're using `EditLog` to refer to the `TxnLog`, please change accordingly to have it consistent across the project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---