Return-Path: <dev-return-55259-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3C60F200C09
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 25 Jan 2017 07:41:25 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 3B069160B50; Wed, 25 Jan 2017 06:41:25 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 89692160B4E
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 25 Jan 2017 07:41:24 +0100 (CET)
Received: (qmail 39124 invoked by uid 500); 25 Jan 2017 06:41:22 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 38916 invoked by uid 99); 25 Jan 2017 06:41:22 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 06:41:22 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A9B7FDFC12; Wed, 25 Jan 2017 06:41:21 +0000 (UTC)
From: rakeshadr <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-156-zookeeper@git.apache.org>
In-Reply-To: <git-pr-156-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #156: ZOOKEEPER-2044:CancelledKeyException in zookeep...
Content-Type: text/plain
Message-Id: <20170125064121.A9B7FDFC12@git1-us-west.apache.org>
Date: Wed, 25 Jan 2017 06:41:21 +0000 (UTC)
archived-at: Wed, 25 Jan 2017 06:41:25 -0000

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/156#discussion_r97716640
  
    --- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java ---
    @@ -68,4 +74,38 @@ public void testOperationsAfterCnxnClose() throws IOException,
                 zk.close();
             }
         }
    +
    +    /**
    +     * Mock extension of NIOServerCnxn to test for
    +     * CancelledKeyException (ZOOKEEPER-2044).
    +     */
    +    class MockNIOServerCnxn extends NIOServerCnxn {
    +        public MockNIOServerCnxn( NIOServerCnxn cnxn )
    +                throws IOException {
    +            super( cnxn.zkServer, cnxn.sock, cnxn.sk, cnxn.factory );
    +        }
    +
    +        public void mockSendBuffer(ByteBuffer bb) throws Exception {
    +            super.internalSendBuffer( bb );
    +        }
    +    }
    +
    +    @Test(timeout = 30000)
    +    public void testValidSelectionKey() throws Exception {
    +        final ZooKeeper zk = createClient();
    +        try {
    +            Iterable<ServerCnxn> connections = serverFactory.getConnections();
    +            for (ServerCnxn serverCnxn : connections) {
    +                MockNIOServerCnxn mock = new MockNIOServerCnxn((NIOServerCnxn) serverCnxn);
    +                // Cancel key
    +                ((NIOServerCnxn) serverCnxn).sock.keyFor(((NIOServerCnxnFactory) serverFactory).selector).cancel();;
    +                mock.mockSendBuffer( ByteBuffer.allocate(8) );
    +            }
    +        } catch (CancelledKeyException e) {
    +            e.printStackTrace();
    --- End diff --
    
    Instead of printStackTrace, can we use LOG.error("Exception while sending bytes!", e);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---