Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: eribeiro <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-150-zookeeper@git.apache.org>
In-Reply-To: <git-pr-150-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...
Content-Type: text/plain
Message-Id: <20170116131718.333B8DFBFF@git1-us-west.apache.org>
Date: Mon, 16 Jan 2017 13:17:18 +0000 (UTC)
archived-at: Mon, 16 Jan 2017 13:17:20 -0000

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/150#discussion_r96226819
  
    --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java ---
    @@ -45,6 +45,9 @@
     
         private int currentIndex = -1;
     
    +    // Don't re-resolve on first next() call
    +    private boolean connectedSinceNext = true;
    --- End diff --
    
    My reasoning was only defensively, but on a 2nd look, it would be overkill. So, no problem without being volatile, imo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---