Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: rakeshadr <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-137-zookeeper@git.apache.org>
In-Reply-To: <git-pr-137-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...
Content-Type: text/plain
Message-Id: <20170116114440.21764DFBDC@git1-us-west.apache.org>
Date: Mon, 16 Jan 2017 11:44:40 +0000 (UTC)
archived-at: Mon, 16 Jan 2017 11:44:42 -0000

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96212537
  
    --- Diff: src/lastRevision.sh ---
    @@ -16,6 +16,6 @@
     
     # Find the current revision, store it in a file
     FILE=$1
    -LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
    +LASTREV=`git rev-parse HEAD | cut -c1-8`
    --- End diff --
    
    Thanks @eribeiro for the patch. Any specific reason to use only the first 8 characters of the git SHA-1. Will this be helpful in analyzing whether a particular fix included in the release?
    
    How about keeping the complete SHA-1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---