Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-140-zookeeper@git.apache.org>
In-Reply-To: <git-pr-140-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #140: ZOOKEEPER-2656: Fix ServerConfigTest#testValidA...
Content-Type: text/plain
Message-Id: <20170104001820.68C4DDFB3D@git1-us-west.apache.org>
Date: Wed,  4 Jan 2017 00:18:20 +0000 (UTC)
archived-at: Wed, 04 Jan 2017 00:18:27 -0000

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/140#discussion_r94511184
  
    --- Diff: src/java/test/org/apache/zookeeper/ServerConfigTest.java ---
    @@ -57,4 +59,16 @@ public void testTooManyArguments() {
             String[] args = {"2181", "/data/dir", "60000", "10000", "9999"};
             serverConfig.parse(args);
         }
    -}
    +
    +    boolean checkEquality(String a, String b) {
    +        return a != null && a.equals(b);
    +    }
    +
    +    boolean checkEquality(String a, File b) {
    +        try {
    +            return a != null && b != null && new File(a).getCanonicalPath().equals(b.getCanonicalPath());
    --- End diff --
    
    @eribeiro code updated to use File.equals, which is less verbose. Thanks for pointing this out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---