zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2672) Remove CHANGE.txt
Date Thu, 26 Jan 2017 02:20:26 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839057#comment-15839057
] 

Michael Han commented on ZOOKEEPER-2672:
----------------------------------------

bq. should we update any of the ZooKeeper docs/cwiki page conveying that github revision log

Good idea, though I can't find a page that correlates to CHANGE.txt on wiki. Any comments
on where we should put such info?

bq. I'm not sure whether any project(internal build tool) referring to ZooKeeper's CHANGE.txt
file and the removal can break it.

CHANGE.txt is already out dated in branch-3.4 - so choosing between keeping an out dated file
in 3.4.10 release, and removing it, at the (low) risk of breaking something that depends on
CHANGE.txt, I vote for removing it in all branches :)

> Remove CHANGE.txt
> -----------------
>
>                 Key: ZOOKEEPER-2672
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2672
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>
> The CHANGE.txt is already not the source of truth of what's changed after we migrating
to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option
of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually
is cumbersome and error prone.
> The consensus is we would rely on source control revision logs instead of CHANGE.txt
moving forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for
more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message