zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
Date Sun, 22 Jan 2017 20:34:27 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833679#comment-15833679
] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
-------------------------------------------

Github user praste commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r97232914
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
    @@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws Exception {
             ClientBase.setupTestEnv();
     
             // setup the logger to capture all logs
    +        LoggerContext loggerContext =  (LoggerContext) LogManager.getContext(false);
    --- End diff --
    
    @jvz - I tried to update tests using the `ListAppender` but I don't think, it is the right
way to verify the log messages. I observed that when I run all the tests in the `QuorumPeerMainTest`
or `ReadOnlyModeTest`, tests fail. However, running 
    following test using `test.method=` option works fine 
    `QuorumPeerMainTest. testInconsistentPeerType` 
    `QuorumPeerMainTest. testQuorumDefaults`
    `QuorumPeerMainTest. testBadPeerAddressInQuorum`
    `ReadOnlyModeTest.testSeekForRwServer`
    
    Not sure what am I missing here.
    
    Let me know what you think.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2659
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
>             Project: ZooKeeper
>          Issue Type: Wish
>            Reporter: Pushkar Raste
>            Assignee: Pushkar Raste
>            Priority: Minor
>         Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. {{log4j 1.X}}
is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message