zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit
Date Wed, 11 Jan 2017 14:50:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818527#comment-15818527
] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
-------------------------------------------

Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/122#discussion_r95591971
  
    --- Diff: src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml ---
    @@ -300,6 +300,11 @@ server.3=125.23.63.25:2782:2785:participant</programlisting>
                   from ZooKeeper class, and use of this API requires ACL setup and user
                   authentication (see <xref linkend="sc_reconfig_access_control"/>
for more information.).
                 </para>
    +
    +            <para>Note: for temporary backward compatibility, the reconfig() APIs
will remain in ZooKeeper.java
    +              where they were for a few alpha versions of 3.5.x. However, these APIs
are deprecated and users
    +              should move to the reconfig() APIs in ZooKeeperAdmin.java.
    --- End diff --
    
    Small typo: `reconfig()` should be `reconfigure()`.


> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-2642
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.5.2
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. It appears
this was done to document that these are methods have access restrictions. However, this change
breaks Apache Curator (and possibly other clients). Curator APIs will have to be changed and/or
special methods need to be added. A breaking change of this kind should only be done when
the benefit is overwhelming. In this case, the same information can be conveyed with documentation
and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() methods back
to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message