zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit
Date Wed, 11 Jan 2017 20:50:17 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819126#comment-15819126
] 

Hadoop QA commented on ZOOKEEPER-2642:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12847073/ZOOKEEPER-2642.patch
  against trunk revision 5f60374d060c18ccad322c7f18883284dbac0fed.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 40 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3559//console

This message is automatically generated.

> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-2642
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.5.2
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. It appears
this was done to document that these are methods have access restrictions. However, this change
breaks Apache Curator (and possibly other clients). Curator APIs will have to be changed and/or
special methods need to be added. A breaking change of this kind should only be done when
the benefit is overwhelming. In this case, the same information can be conveyed with documentation
and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() methods back
to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message