zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit
Date Tue, 17 Jan 2017 14:37:27 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826128#comment-15826128
] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
-------------------------------------------

GitHub user Randgalt opened a pull request:

    https://github.com/apache/zookeeper/pull/151

    Applying ZOOKEEPER-2642 patch to a 3.5 base

    New PR that applies ZOOKEEPER-2642 to `branch-3.5`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2642-3.5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #151
    
----
commit d92dc5869269e041e4246428946455fb7d404ff4
Author: randgalt <jordan@jordanzimmerman.com>
Date:   2017-01-17T14:35:39Z

    Applying ZOOKEEPER-2642 patch to a 3.5 base

----


> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-2642
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.5.2
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. It appears
this was done to document that these are methods have access restrictions. However, this change
breaks Apache Curator (and possibly other clients). Curator APIs will have to be changed and/or
special methods need to be added. A breaking change of this kind should only be done when
the benefit is overwhelming. In this case, the same information can be conveyed with documentation
and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() methods back
to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message