zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo
Date Wed, 18 Jan 2017 14:45:26 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828193#comment-15828193
] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
-------------------------------------------

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96649084
  
    --- Diff: src/java/main/org/apache/zookeeper/Version.java ---
    @@ -20,7 +20,7 @@
     
     public class Version implements org.apache.zookeeper.version.Info {
     
    -    public static int getRevision() {
    +    public static String getRevision() {
    --- End diff --
    
    I have checked with my HBase colleagues, they said no dependency with "revision". From
ZK point of view, not required to maintain backward compatibility as this is not exposed interface.
Still, if any concerns, then we can deprecate and create a new GIT_REVISION or REVISION_HASH
etc as this change will go to stable branch-3.4


> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
>                 Key: ZOOKEEPER-2573
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Arshad Mohammad
>            Assignee: Edward Ribeiro
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo revision
which is of type int
> But after migrating to git repo the git repo's revision(commit 63f5132716c08b3d8f18993bf98eb46eb42f80fb)
can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable to store
the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message