zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo
Date Wed, 25 Jan 2017 12:32:26 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837646#comment-15837646
] 

Rakesh R commented on ZOOKEEPER-2573:
-------------------------------------

Thanks [~eribeiro] for the contribution. Thanks [~hanm], [~arshad.mohammad] for the reviews.

Committed to branch-3.4:
https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commit;h=d6bbfd76d24c044073764c5d074a9198c69fafab

Committed to branch-3.5:
https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commit;h=41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc

Committed to master:
https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commit;h=8771ffdaacb87126a485ae740558f6a288ab980b

> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
>                 Key: ZOOKEEPER-2573
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Mohammad Arshad
>            Assignee: Edward Ribeiro
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo revision
which is of type int
> But after migrating to git repo the git repo's revision(commit 63f5132716c08b3d8f18993bf98eb46eb42f80fb)
can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable to store
the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message