zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo
Date Tue, 24 Jan 2017 19:02:29 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836409#comment-15836409
] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
-------------------------------------------

GitHub user eribeiro opened a pull request:

    https://github.com/apache/zookeeper/pull/155

    ZOOKEEPER-2573: Modify Info.REVISION to adapt git repo

    @rakeshadr Hi, I have created this PR. The commit can be cherry picked on master too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2573-3.5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 7ca175dfadf5220a3495e3e19de4b933df37fc50
Author: Edward Ribeiro <edward.ribeiro@gmail.com>
Date:   2016-12-28T17:21:31Z

    ZOOKEEPER-2573: Modify Info.REVISION to adapt git repo

----


> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
>                 Key: ZOOKEEPER-2573
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Mohammad Arshad
>            Assignee: Edward Ribeiro
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo revision
which is of type int
> But after migrating to git repo the git repo's revision(commit 63f5132716c08b3d8f18993bf98eb46eb42f80fb)
can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable to store
the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message