zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2511) Implement AutoCloseable in ZooKeeper.java
Date Fri, 06 Jan 2017 18:36:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805248#comment-15805248
] 

ASF GitHub Bot commented on ZOOKEEPER-2511:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/143#discussion_r94995400
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -127,7 +127,13 @@
      * EventNone and state sKeeperStateDisconnected.
      *
      */
    -public class ZooKeeper {
    +// We suppress the "try" warning here because the close() method's signature
    --- End diff --
    
    I used // comments to clarify the separation between this comment and the javadoc (since
I believe the information is only important when compiling zookeeper). Let me know if you
think that is valid.


> Implement AutoCloseable in ZooKeeper.java
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2511
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2511
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>             Fix For: 3.5.3
>
>         Attachments: ZOOKEEPER-2511.patch
>
>
> As a java developer I would like to be able to use try-with-resource blocks with ZooKeeper
objects in order to make closing sessions easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message