zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2359) ZooKeeper client has unnecessary logs for watcher removal errors
Date Tue, 24 Jan 2017 22:30:26 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836759#comment-15836759
] 

Michael Han commented on ZOOKEEPER-2359:
----------------------------------------

Thanks Edward for review, this patch LGTM. [~arshadmohammad], please take a look and commit
if it looks OK to you (for new committer muscle exercise.).

> ZooKeeper client has unnecessary logs for watcher removal errors
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2359
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2359
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.5.1
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>         Attachments: ZOOKEEPER-2359.patch
>
>
> ClientCnxn.java logs errors during watcher removal:
> LOG.error("Failed to find watcher!", nwe);
> LOG.error("Exception when removing watcher", ke);
> An error code/exception is generated so the logs are noisy and unnecessary. If the client
handles the error there's still a log message. This is different than other APIs. These logs
should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message