zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing
Date Sat, 07 Jan 2017 00:51:59 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806330#comment-15806330

ASF GitHub Bot commented on ZOOKEEPER-2325:

GitHub user hanm opened a pull request:


    ZOOKEEPER-2325 for branch-3.4.

    There was a merge conflict on file Zab1_0Test.java when cherry-picking commit 7c51b01e89acb38165553366f7e3b2a46c00aa27
to branch-3.4. This PR resolves the merge conflict (it is trivial, just two imports conflicts).
    @breed @rgs1 @rakeshadr Please take a look and help committing this thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2325

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
commit afd34f286c860591f1e26b1c29539b322cef7bcc
Author: Benjamin Reed <br33d@fb.com>
Date:   2017-01-07T00:09:54Z

    ZOOKEEPER-2325 (Data inconsistency if all snapshots empty or missing) for branch-3.4.
    Resolved merge conflict on Zab1_0Test.java when cherry-picking 7c51b01e89acb38165553366f7e3b2a46c00aa27.


> Data inconsistency if all snapshots empty or missing
> ----------------------------------------------------
>                 Key: ZOOKEEPER-2325
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.6
>            Reporter: Andrew Grasso
>            Assignee: Andrew Grasso
>            Priority: Critical
>             Fix For: 3.5.3, 3.6.0
>         Attachments: ZOOKEEPER-2325-test.patch, ZOOKEEPER-2325.001.patch, zk.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the result
of FileSnap.deserialize, which is -1L if no valid snapshots are found. Recovery proceeds with
dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin serving
requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.

This message was sent by Atlassian JIRA

View raw message