zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpj <...@git.apache.org>
Subject [GitHub] zookeeper pull request #157: ZOOKEEPER-2678: Discovery and Sync can take a v...
Date Sat, 28 Jan 2017 19:15:35 GMT
Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/157#discussion_r98337403
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ---
    @@ -839,6 +839,13 @@ public void converseWithFollower(InputArchive ia, OutputArchive oa,
                         Assert.assertEquals(1, f.self.getAcceptedEpoch());
                         Assert.assertEquals(1, f.self.getCurrentEpoch());
                         
    +                    //Wait for the edits to be written out
    --- End diff --
    
    I need to think some more whether it makes any sense to add test cases for this. The test
cases we already have probably cover this enough given that there is no real change of behavior.
    
    This change here is necessary, though. We don't really care about time in general in our
tests because we can never be sure of the timing we will get across runs and with different
settings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message