zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From praste <...@git.apache.org>
Subject [GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration
Date Thu, 26 Jan 2017 15:16:26 GMT
Github user praste commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r98013864
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
    @@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws Exception {
             ClientBase.setupTestEnv();
     
             // setup the logger to capture all logs
    +        LoggerContext loggerContext =  (LoggerContext) LogManager.getContext(false);
    --- End diff --
    
    @jvz is using ListAppender absolutely necessary? 
    
    Can we merge this with  current changes? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message