zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From praste <...@git.apache.org>
Subject [GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration
Date Sun, 22 Jan 2017 20:34:24 GMT
Github user praste commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r97232914
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
    @@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws Exception {
             ClientBase.setupTestEnv();
     
             // setup the logger to capture all logs
    +        LoggerContext loggerContext =  (LoggerContext) LogManager.getContext(false);
    --- End diff --
    
    @jvz - I tried to update tests using the `ListAppender` but I don't think, it is the right
way to verify the log messages. I observed that when I run all the tests in the `QuorumPeerMainTest`
or `ReadOnlyModeTest`, tests fail. However, running 
    following test using `test.method=` option works fine 
    `QuorumPeerMainTest. testInconsistentPeerType` 
    `QuorumPeerMainTest. testQuorumDefaults`
    `QuorumPeerMainTest. testBadPeerAddressInQuorum`
    `ReadOnlyModeTest.testSeekForRwServer`
    
    Not sure what am I missing here.
    
    Let me know what you think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message