zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...
Date Wed, 18 Jan 2017 18:16:43 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/150#discussion_r96699234
  
    --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java ---
    @@ -57,26 +62,20 @@
         public StaticHostProvider(Collection<InetSocketAddress> serverAddresses)
                 throws UnknownHostException {
             for (InetSocketAddress address : serverAddresses) {
    -            InetAddress ia = address.getAddress();
    -            InetAddress resolvedAddresses[] = InetAddress.getAllByName((ia!=null) ? ia.getHostAddress():
    -                address.getHostName());
    +            InetAddress resolvedAddresses[];
    +            try {
    --- End diff --
    
    It might be better to wrap the reflection in an abstraction in a static block in this
file so inspection of the class will be done only once, save some runtime inspection cycles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message