zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...
Date Wed, 18 Jan 2017 14:44:39 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96649084
  
    --- Diff: src/java/main/org/apache/zookeeper/Version.java ---
    @@ -20,7 +20,7 @@
     
     public class Version implements org.apache.zookeeper.version.Info {
     
    -    public static int getRevision() {
    +    public static String getRevision() {
    --- End diff --
    
    I have checked with my HBase colleagues, they said no dependency with "revision". From
ZK point of view, not required to maintain backward compatibility as this is not exposed interface.
Still, if any concerns, then we can deprecate and create a new GIT_REVISION or REVISION_HASH
etc as this change will go to stable branch-3.4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message