zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...
Date Wed, 18 Jan 2017 13:48:04 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96636920
  
    --- Diff: src/java/main/org/apache/zookeeper/Version.java ---
    @@ -20,7 +20,7 @@
     
     public class Version implements org.apache.zookeeper.version.Info {
     
    -    public static int getRevision() {
    +    public static String getRevision() {
    --- End diff --
    
    @rakeshadr My Google searches didn't bring anything about external  ZK revision number
use. Of course, many in-house systems can rely on it. So, I am clueless about the best strategy
here. :(
    
    It would be quite annoying to break internal build tools, but this is an unfortunate side
effect of a fundamental infra change (VCS). :(
    
    @fpj wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message