zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...
Date Mon, 16 Jan 2017 13:08:57 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96225530
  
    --- Diff: src/lastRevision.sh ---
    @@ -16,6 +16,6 @@
     
     # Find the current revision, store it in a file
     FILE=$1
    -LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
    +LASTREV=`git rev-parse HEAD | cut -c1-8`
    --- End diff --
    
    Hi @rakeskadr, usually the first 8 characters of commit are enough to identify the commit.
    
    But I think putting the whole SHA-1 is nice, because the more context the better. Also,
it simplifies the code even more (to substr the sha1 is annoying on windows).
    
    Thanks for pointing out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message