zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...
Date Mon, 16 Jan 2017 12:29:09 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/137#discussion_r96218924
  
    --- Diff: src/java/main/org/apache/zookeeper/Version.java ---
    @@ -20,7 +20,7 @@
     
     public class Version implements org.apache.zookeeper.version.Info {
     
    -    public static int getRevision() {
    +    public static String getRevision() {
    --- End diff --
    
    Since this is not an exposed interface it is OK to change the signature. But, I'm curious
to know that any other project or users depending on the revision number.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message