zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvz <...@git.apache.org>
Subject [GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration
Date Mon, 16 Jan 2017 03:33:12 GMT
Github user jvz commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r96145091
  
    --- Diff: ivy.xml ---
    @@ -41,13 +41,20 @@
     
       <dependencies>
         <dependency org="org.slf4j" name="slf4j-api" rev="1.7.5"/>
    -    <dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.5" transitive="false"/>
    +    
    +    <dependency org="org.apache.logging.log4j" name="log4j-api" rev="2.7" transitive="false"/>
    +    <dependency org="org.apache.logging.log4j" name="log4j-core" rev="2.7" transitive="false"/>
    +    <dependency org="org.apache.logging.log4j" name="log4j-slf4j-impl" rev="2.7" transitive="false"/>
    +
    +    <!-- disruptor for Async loggers -->    
    +    <dependency org="com.lmax" name="disruptor" rev="3.3.0" transitive="false"/>
    +    
         <dependency org="commons-cli" name="commons-cli" rev="1.2" />
       
         <dependency org="org.apache.maven.wagon" name="wagon-http" rev="2.4" conf="mvn-ant-task->default"/>
         <dependency org="org.apache.maven" name="maven-ant-tasks" rev="2.1.3" conf="mvn-ant-task->master"/>
         <!-- transitive false turns off dependency checking, log4j deps seem borked -->
    -    <dependency org="log4j" name="log4j" rev="1.2.17" transitive="false"/>
    +    <!-- dependency org="log4j" name="log4j" rev="1.2.17" transitive="false"/ -->
    --- End diff --
    
    If anything is using log4j 1's API still, you'll need `log4j-1.2-api` as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message