zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From enixon <...@git.apache.org>
Subject [GitHub] zookeeper pull request #120: ZOOKEEPER-261
Date Thu, 12 Jan 2017 02:12:40 GMT
Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/120#discussion_r95714094
  
    --- Diff: bin/zkServer-initialize.sh ---
    @@ -113,6 +113,8 @@ initialize() {
         else
             echo "No myid provided, be sure to specify it in $ZOO_DATADIR/myid if using non-standalone"
         fi
    +
    +    date > "$ZOO_DATADIR/initialize"
    --- End diff --
    
    True enough, `touch` is sufficient. Using `date` is an optimization I've included in other
scripts in the past as a way of sneaking a bit more information into an otherwise meaningless
file but in this context it's probably just confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message