zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #120: ZOOKEEPER-261
Date Thu, 12 Jan 2017 01:26:37 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/120#discussion_r95707294
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
    @@ -167,6 +175,16 @@ public long restore(DataTree dt, Map<Long, Integer> sessions,
                 PlayBackListener listener) throws IOException {
             long deserializeResult = snapLog.deserialize(dt, sessions);
             FileTxnLog txnLog = new FileTxnLog(dataDir);
    +        boolean suspectEmptyDB;
    +        File initFile = new File(dataDir.getParent(), "initialize");
    +        if (initFile.exists()) {
    --- End diff --
    
    As Java 7 is the default we could use the code below? The benefits are that it automatically
throws the `IOException` if an I/O error happens or return `false` if the file doesn't exists.
    
    ```
    if (Files.deleteIfExists(initFile.toPath()) {
        suspectEmptyDB = false;
    } else {
    (...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message