zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #143: ZOOKEEPER-2511: Implement AutoCloseable in ZooK...
Date Fri, 06 Jan 2017 18:36:24 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/143#discussion_r94995400
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -127,7 +127,13 @@
      * EventNone and state sKeeperStateDisconnected.
      *
      */
    -public class ZooKeeper {
    +// We suppress the "try" warning here because the close() method's signature
    --- End diff --
    
    I used // comments to clarify the separation between this comment and the javadoc (since
I believe the information is only important when compiling zookeeper). Let me know if you
think that is valid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message