zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #140: ZOOKEEPER-2656: Fix ServerConfigTest#testValidA...
Date Wed, 04 Jan 2017 00:09:04 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/140#discussion_r94510206
  
    --- Diff: src/java/test/org/apache/zookeeper/ServerConfigTest.java ---
    @@ -57,4 +59,16 @@ public void testTooManyArguments() {
             String[] args = {"2181", "/data/dir", "60000", "10000", "9999"};
             serverConfig.parse(args);
         }
    -}
    +
    +    boolean checkEquality(String a, String b) {
    +        return a != null && a.equals(b);
    +    }
    +
    +    boolean checkEquality(String a, File b) {
    +        try {
    +            return a != null && b != null && new File(a).getCanonicalPath().equals(b.getCanonicalPath());
    --- End diff --
    
    Also, ``checkEquality(null, null)`` here will be false. We want this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message