Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DFEEF200BCF for ; Mon, 5 Dec 2016 20:19:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DE9E5160B18; Mon, 5 Dec 2016 19:19:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 59D1B160B09 for ; Mon, 5 Dec 2016 20:19:02 +0100 (CET) Received: (qmail 78989 invoked by uid 500); 5 Dec 2016 19:19:00 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 78497 invoked by uid 99); 5 Dec 2016 19:19:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2016 19:19:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 493E8E076F; Mon, 5 Dec 2016 19:19:00 +0000 (UTC) From: yufeldman To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes... Content-Type: text/plain Message-Id: <20161205191900.493E8E076F@git1-us-west.apache.org> Date: Mon, 5 Dec 2016 19:19:00 +0000 (UTC) archived-at: Mon, 05 Dec 2016 19:19:03 -0000 Github user yufeldman commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r90935413 --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java --- @@ -71,7 +71,7 @@ NettyServerCnxnFactory factory; boolean initialized; - NettyServerCnxn(Channel channel, ZooKeeperServer zks, NettyServerCnxnFactory factory) { + public NettyServerCnxn(Channel channel, ZooKeeperServer zks, NettyServerCnxnFactory factory) { --- End diff -- @hanm - there is nothing wrong with the tests, they do run fine. They do not use ctor from NettyServerCnxn, but from MockNettyServerCnxn - that has public ctor. You can make MockNettyServerCnxn not public and you will have the same issue. And BTW org.apache.zookeeper.server.NettyServerCnxnTest fails with not public ctor in NettyServerCnxn --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---