zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit
Date Sat, 10 Dec 2016 19:37:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738368#comment-15738368
] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
-------------------------------------------

GitHub user Randgalt opened a pull request:

    https://github.com/apache/zookeeper/pull/122

    [ZOOKEEPER-2642] Resurrect the reconfig() methods that were in ZooKeeper.java.

    Resurrect the reconfig() methods that were in ZooKeeper.java. While 3.5.x is an alpha
there are clients in production that are relying on the current specification. The reconfig()
methods are marked deprecated to inform that they will be removed later. The "new" methods
in the new class ZooKeeperAdmin were renamed reconfigure() to avoid getting the deprecation
annotation inherited and to provide clarity. Both reconfig() and reconfigure() are implemented
via protected methods in ZooKeeper.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2642

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #122
    
----
commit 3611d18eb73bac5760293730087d2b0c3241b2bc
Author: randgalt <jordan@jordanzimmerman.com>
Date:   2016-12-10T19:33:58Z

    Resurrect the reconfig() methods that were in ZooKeeper.java. While 3.5.x is an alpha
there are clients in production that are relying
    on the current specification. The reconfig() methods are marked deprecated to inform that
they will be removed later. The "new" methods
    in the new class ZooKeeperAdmin were renamed reconfigure() to avoid getting the deprecation
annotation inherited and to provide clarity.
    Both reconfig() and reconfigure() are implemented via protected methods in ZooKeeper.java

----


> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-2642
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.5.2
>            Reporter: Jordan Zimmerman
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. It appears
this was done to document that these are methods have access restrictions. However, this change
breaks Apache Curator (and possibly other clients). Curator APIs will have to be changed and/or
special methods need to be added. A breaking change of this kind should only be done when
the benefit is overwhelming. In this case, the same information can be conveyed with documentation
and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() methods back
to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message