zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1364) Add orthogonal fault injection mechanism/framework
Date Wed, 14 Dec 2016 16:59:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748858#comment-15748858
] 

ASF GitHub Bot commented on ZOOKEEPER-1364:
-------------------------------------------

Github user eribeiro commented on the issue:

    https://github.com/apache/zookeeper/pull/123
  
    @yufeldman Sure, totally agree about this being a separate issue! :+1: 
    
    My only concern is that **IF** we decide to introduce this injection framework into ZK
**after merging ZOOKEEPER-2549** then some of the mocking and reflection changes introduced
by ZOOKEEPER-2549 for the purposes of testing become redundant, so basically we would have
to undo parts of it (but not the bug fix, of course). See this PR for a concrete idea of what
I am trying to say.
    
    But you raised a very important point: **ZOOKEEPER-2549 is critical, and delaying its
merging is gonna be bad for the project release, IMHO.** So, I am all for you keep going your
work (congrats, btw) and run this as a future issue. Or whatever the committers find more
suitable.  /cc @fpj @rgs1 @hanm @phunt



> Add orthogonal fault injection mechanism/framework
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-1364
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1364
>             Project: ZooKeeper
>          Issue Type: Test
>          Components: tests
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>
> Hadoop has a mechanism for doing fault injection (HDFS-435). I think it would be useful
if something similar would be available for ZooKeeper. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message