zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper issue #99: ZOOKEEPER-2549 Add exception handling to sendResponse
Date Wed, 14 Dec 2016 00:25:51 GMT
Github user eribeiro commented on the issue:

    https://github.com/apache/zookeeper/pull/99
  
    I like this patch, but I think the whole reflection/mock thing is kind of reinventing
a fault injection inside the test classes. If so, why not use a production ready framework
as Byteman? I wrote a PR that strips the boilerplate stuff while leaving the feature of this
PR: https://github.com/apache/zookeeper/pull/123 
    
    Still a PoC, so any suggestions are welcome. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message