zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #120: ZOOKEEPER-261
Date Wed, 07 Dec 2016 06:59:39 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/120#discussion_r91235960
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
    @@ -132,6 +137,9 @@ public FileTxnSnapLog(File dataDir, File snapDir) throws IOException
{
     
             txnLog = new FileTxnLog(this.dataDir);
             snapLog = new FileSnap(this.snapDir);
    +
    +        autoCreateDB = Boolean.parseBoolean(System.getProperty(ZOOKEEPER_DB_AUTOCREATE,
    --- End diff --
    
    >> Is that in accord with Zookeeper style?
    
    I see - I thought the new property was not end user facing since there is no associated
documents added here. Since the property "zookeeper.db.autocreate" is exposed to user some
doc could be added to ZooKeeperAdmin.html (similarly like how the existing "zookeeper.datadir.autocreate"
is documented there) to describe the motivation / usage of the property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message