zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yufeldman <...@git.apache.org>
Subject [GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...
Date Mon, 05 Dec 2016 19:19:00 GMT
Github user yufeldman commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/99#discussion_r90935413
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
    @@ -71,7 +71,7 @@
         NettyServerCnxnFactory factory;
         boolean initialized;
         
    -    NettyServerCnxn(Channel channel, ZooKeeperServer zks, NettyServerCnxnFactory factory)
{
    +    public NettyServerCnxn(Channel channel, ZooKeeperServer zks, NettyServerCnxnFactory
factory) {
    --- End diff --
    
    @hanm - there is nothing wrong with the tests, they do run fine. They do not use ctor
from NettyServerCnxn, but from MockNettyServerCnxn - that has public ctor.
    You can make MockNettyServerCnxn not public and you will have the same issue. And BTW

    org.apache.zookeeper.server.NettyServerCnxnTest fails with not public ctor in NettyServerCnxn



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message