Return-Path: <dev-return-52063-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C0ED5200BB1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  3 Nov 2016 17:26:01 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id BE3D3160B0F; Thu,  3 Nov 2016 16:26:01 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0FB15160B10
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  3 Nov 2016 17:26:00 +0100 (CET)
Received: (qmail 72631 invoked by uid 500); 3 Nov 2016 16:25:59 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 72324 invoked by uid 99); 3 Nov 2016 16:25:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 16:25:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 4C0E52C2AC1
	for <dev@zookeeper.apache.org>; Thu,  3 Nov 2016 16:25:59 +0000 (UTC)
Date: Thu, 3 Nov 2016 16:25:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13016585.1477915953000.175238.1478190359309@Atlassian.JIRA>
In-Reply-To: <JIRA.13016585.1477915953000@Atlassian.JIRA>
References: <JIRA.13016585.1477915953000@Atlassian.JIRA> <JIRA.13016585.1477915953390@arcas>
Subject: [jira] [Commented] (ZOOKEEPER-2624) Add test script for pull
 requests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 03 Nov 2016 16:26:01 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633332#comment-15633332 ] 

ASF GitHub Bot commented on ZOOKEEPER-2624:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/97#discussion_r86384484
  
    --- Diff: build.xml ---
    @@ -1622,6 +1623,26 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
         	</exec>
          </target>
     
    +     <target name="qa-test-pullrequest" depends="findbugs.check,forrest.check">
    +        <exec executable="bash" failonerror="true">
    +                <arg value="${test_pullrequest_sh}"/>
    +                <arg value="QABUILD"/>
    +                <arg value="${scratch.dir}"/>
    +                <arg value="${ps.cmd}"/>
    +                <arg value="${wget.cmd}"/>
    +                <arg value="${jiracli.cmd}"/>
    +                <arg value="${git.cmd}"/>
    +                <arg value="${grep.cmd}"/>
    +                <arg value="${patch.cmd}"/>
    +                <arg value="${findbugs.home}"/>
    +                <arg value="${forrest.home}"/>
    +                <arg value="${basedir}"/>
    +                <arg value="${jira.passwd}"/>
    +                <arg value="${java5.home}"/>
    +                <arg value="${curl.cmd}"/>
    --- End diff --
    
    There was a '<arg value="${defect}"/>' in test-patch.sh but missing here - is this intentionally left out? 


> Add test script for pull requests
> ---------------------------------
>
>                 Key: ZOOKEEPER-2624
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)