Return-Path: <dev-return-52696-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 729F6200BCE
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 18 Nov 2016 06:50:09 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 71605160B18; Fri, 18 Nov 2016 05:50:09 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E1BBC160B0B
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 18 Nov 2016 06:50:08 +0100 (CET)
Received: (qmail 64274 invoked by uid 500); 18 Nov 2016 05:50:08 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 64249 invoked by uid 99); 18 Nov 2016 05:50:07 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Nov 2016 05:50:07 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 009C7E2F35; Fri, 18 Nov 2016 05:50:06 +0000 (UTC)
From: rgs1 <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-98-zookeeper@git.apache.org>
In-Reply-To: <git-pr-98-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #98: ZOOKEEPER-2479
Content-Type: text/plain
Message-Id: <20161118055007.009C7E2F35@git1-us-west.apache.org>
Date: Fri, 18 Nov 2016 05:50:06 +0000 (UTC)
archived-at: Fri, 18 Nov 2016 05:50:09 -0000

Github user rgs1 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/98#discussion_r88602842
  
    --- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java ---
    @@ -36,7 +38,30 @@
         /***************************************************************/
         @Test
         public void testMajQuorums() throws Throwable {
    -       
    +        LOG.info("Verify QuorumPeer#electionTimeTaken jmx bean attribute");
    +
    +        ArrayList<QuorumPeer> peers = getPeerList();
    +        for (int i = 1; i <= peers.size(); i++) {
    +            QuorumPeer qp = peers.get(i - 1);
    +            Long electionTimeTaken = -1L;
    +            String bean = "";
    +            if (qp.getPeerState() == ServerState.FOLLOWING) {
    +                bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + i
    +                        + ",name1=replica." + i + ",name2=Follower";
    --- End diff --
    
    hyper nit: `String.format()` reads better than `+`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---