zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings
Date Wed, 23 Nov 2016 10:13:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689660#comment-15689660
] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
-------------------------------------------

Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/102#discussion_r89283922
  
    --- Diff: src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
    @@ -151,9 +153,13 @@
          */
         public final static int telnetCloseCmd = 0xfff4fffd;
     
    -    public final static HashMap<Integer, String> cmd2String =
    +    final static HashMap<Integer, String> cmd2String =
    --- End diff --
    
    If we can remove this `public`, then I think we should. Also agree with the consistent
`Map` declaration comment.


> Investigate and fix findbug warnings
> ------------------------------------
>
>                 Key: ZOOKEEPER-2628
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>             Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to Infra team,
and this leads to 20 new warnings produced by findbug. The warning reports can be found on
[pre commit builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build number
>= 3513. These warnings need to be triaged and fixed if they are legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message