zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests
Date Thu, 03 Nov 2016 16:25:59 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633332#comment-15633332
] 

ASF GitHub Bot commented on ZOOKEEPER-2624:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/97#discussion_r86384484
  
    --- Diff: build.xml ---
    @@ -1622,6 +1623,26 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
         	</exec>
          </target>
     
    +     <target name="qa-test-pullrequest" depends="findbugs.check,forrest.check">
    +        <exec executable="bash" failonerror="true">
    +                <arg value="${test_pullrequest_sh}"/>
    +                <arg value="QABUILD"/>
    +                <arg value="${scratch.dir}"/>
    +                <arg value="${ps.cmd}"/>
    +                <arg value="${wget.cmd}"/>
    +                <arg value="${jiracli.cmd}"/>
    +                <arg value="${git.cmd}"/>
    +                <arg value="${grep.cmd}"/>
    +                <arg value="${patch.cmd}"/>
    +                <arg value="${findbugs.home}"/>
    +                <arg value="${forrest.home}"/>
    +                <arg value="${basedir}"/>
    +                <arg value="${jira.passwd}"/>
    +                <arg value="${java5.home}"/>
    +                <arg value="${curl.cmd}"/>
    --- End diff --
    
    There was a '<arg value="${defect}"/>' in test-patch.sh but missing here - is this
intentionally left out? 


> Add test script for pull requests
> ---------------------------------
>
>                 Key: ZOOKEEPER-2624
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message