zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files
Date Fri, 18 Nov 2016 05:24:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675825#comment-15675825

Rakesh R commented on ZOOKEEPER-2574:

Yes, I've identified few occurrences in the doc. One more [comment|https://issues.apache.org/jira/browse/ZOOKEEPER-2574?focusedCommentId=15643171&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15643171]
is open and has to be fixed. Probably, we could do more detailed reviews and all such cases
has to be re-phrased as there was a behavioral change due to the [Learner snapshotting logic|https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/server/quorum/Learner.java#L439].

> PurgeTxnLog can inadvertently delete required txn log files
> -----------------------------------------------------------
>                 Key: ZOOKEEPER-2574
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2574
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.7, 3.4.8, 3.5.0, 3.5.1, 3.5.2
>         Environment: Zookeeper 3.4.8, standalone, and 3-server quorum
>            Reporter: Abhishek Rai
>            Assignee: Abhishek Rai
>             Fix For: 3.4.10, 3.5.3
>         Attachments: ZOOKEEPER-2574.2.patch, ZOOKEEPER-2574.3.patch, ZOOKEEPER-2574.4.patch,
ZOOKEEPER-2574.5.patch, ZOOKEEPER-2574.6.patch, ZOOKEEPER-2574.patch
> As part of the fix for ZOOKEEPER-1797, the call to FileTxnSnapLog.getSnapshotLogs() was
removed from PurgeTxnLog.java.  As a result, some old-looking but required txn log files can
be deleted, resulting in data corruption or loss.
> For example, consider the following:
> 1. Configuration:
> autopurge.snapRetainCount=3
> 2. Following files exist:
> log.100 spans transactions from zxid=100 till zxid=140 (inclusive)
> snapshot.110 - snapshot as of zxid=110
> snapshot.120 - snapshot as of zxid=120
> snapshot.130 - snapshot as of zxid=130
> Above scenario is possible when snapshotting has happened multiple times but without
accompanying log rollover, which is possible if the server was running as a learner.
> 3. PurgeTxnLog retains all snapshots but deletes log.100 because its zxid is older than
the zxid of the oldest snapshot (110).  This results in loss of transactions in the range
> Before the fix for ZOOKEEPER-1797, this was avoided by the call to FileTxnSnapLog.getSnapshotLogs()
which finds and retains the newest txn log file with starting zxid < oldest retained snapshot's
highest zxid.

This message was sent by Atlassian JIRA

View raw message