zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread
Date Sun, 06 Nov 2016 05:15:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641172#comment-15641172
] 

ASF GitHub Bot commented on ZOOKEEPER-2549:
-------------------------------------------

Github user rgs1 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/99#discussion_r86679205
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
    @@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
     
         protected NIOServerCnxn createConnection(SocketChannel sock,
                 SelectionKey sk, SelectorThread selectorThread) throws IOException {
    -        return new NIOServerCnxn(zkServer, sock, sk, this, selectorThread);
    +
    +        NIOServerCnxn cnxn = null;
    +
    +        if (serverCnxnClassCtr != null) {
    --- End diff --
    
    what's wrong with setting serverCnxnClassCtr to NettyServerCnxn by default (by doing all
the reflection magic)?


> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main
ZK requests processing thread
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2549
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2549
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.1
>            Reporter: Yuliya Feldman
>            Assignee: Yuliya Feldman
>         Attachments: ZOOKEEPER-2549-2.patch, ZOOKEEPER-2549-3.patch, ZOOKEEPER-2549-3.patch,
ZOOKEEPER-2549.patch, ZOOKEEPER-2549.patch, zookeeper-2549-1.patch
>
>
> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main
ZK requests processing thread and make Zookeeper server look like it is hanging, while it
just can not process any request anymore.
> Idea is to catch all the exceptions in NettyServerCnxn.sendResponse() , convert them
to IOException and allow it propagating up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message