zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2420) Autopurge deletes log file prior to oldest retained snapshot even though restore may need it
Date Mon, 14 Nov 2016 06:32:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662934#comment-15662934
] 

Hadoop QA commented on ZOOKEEPER-2420:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12806310/ZOOKEEPER-2420.patch_v3
  against trunk revision 73e102a58d01b27bc6208bbfbde2d12f0deba1f4.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 20 new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3532//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3532//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3532//console

This message is automatically generated.

> Autopurge deletes log file prior to oldest retained snapshot even though restore may
need it
> --------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2420
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2420
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Ed Rowe
>            Assignee: Ed Rowe
>         Attachments: ZOOKEEPER-2420.patch, ZOOKEEPER-2420.patch_v2, ZOOKEEPER-2420.patch_v3
>
>
> Autopurge retains all log files whose zxid are >= the zxid of the oldest snapshot
file that it is going to retain (in PurgeTxnLog retainNRecentSnapshots()). However, unless
there is a log file with the same zxid as the oldest snapshot file being retained (and whether
log file and snapshot file zxids are equal is timing dependent), loading the database from
snapshots/logs will start with the log file _prior_ to the snapshot's zxid. Thus, to avoid
data loss autopurge should retain the log file prior to the oldest retained snapshot as well,
unless it verifies that it contains no zxids beyond what the snapshot contains or there is
a log file whose zxid == snapshot zxid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message