zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2420) Autopurge deletes log file prior to oldest retained snapshot even though restore may need it
Date Mon, 14 Nov 2016 06:13:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662891#comment-15662891
] 

Rakesh R commented on ZOOKEEPER-2420:
-------------------------------------

Thanks [~EdRowe] for the good work.

Hi All,  

Like [~hanm] pointed out, both this jira and ZOOKEEPER-2574 are addressing same case. Could
you please look at [my comments in ZK-2574 jira|https://issues.apache.org/jira/browse/ZOOKEEPER-2574?focusedCommentId=15662873&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15662873]
and let me know your thoughts. Based on your feedback will take an action. Thanks!

> Autopurge deletes log file prior to oldest retained snapshot even though restore may
need it
> --------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2420
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2420
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Ed Rowe
>            Assignee: Ed Rowe
>         Attachments: ZOOKEEPER-2420.patch, ZOOKEEPER-2420.patch_v2, ZOOKEEPER-2420.patch_v3
>
>
> Autopurge retains all log files whose zxid are >= the zxid of the oldest snapshot
file that it is going to retain (in PurgeTxnLog retainNRecentSnapshots()). However, unless
there is a log file with the same zxid as the oldest snapshot file being retained (and whether
log file and snapshot file zxids are equal is timing dependent), loading the database from
snapshots/logs will start with the log file _prior_ to the snapshot's zxid. Thus, to avoid
data loss autopurge should retain the log file prior to the oldest retained snapshot as well,
unless it verifies that it contains no zxids beyond what the snapshot contains or there is
a log file whose zxid == snapshot zxid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message