zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster
Date Sun, 06 Nov 2016 05:43:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641215#comment-15641215
] 

ASF GitHub Bot commented on ZOOKEEPER-2014:
-------------------------------------------

Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/96#discussion_r86679075
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
    @@ -356,7 +356,7 @@ private static int getPort(String hostPort) {
          */
         public static void startServerInstance(File dataDir,
                 ServerCnxnFactory factory, String hostPort) throws IOException,
    -            InterruptedException {
    +            InterruptedException, KeeperException.NoNodeException {
    --- End diff --
    
    this isn't needed anymore right?


> Only admin should be allowed to reconfig a cluster
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-2014
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Michael Han
>            Priority: Blocker
>             Fix For: 3.5.3
>
>         Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch,
ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch,
ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch,
ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We should,
at the very least, ensure that only the Admin can reconfigure a cluster. Perhaps restricting
access to /zookeeper/config as well, though this is debatable. Surely one could ensure Admin
only access via an ACL, but that would leave everyone who doesn't use ACLs unprotected. We
could also force a default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run with zookeeper.DigestAuthenticationProvider.superDigest
(which I am not sure if everyone does, or how would it work with other authentication providers).

> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message