zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins
Date Tue, 15 Nov 2016 06:57:58 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666314#comment-15666314
] 

ASF GitHub Bot commented on ZOOKEEPER-1525:
-------------------------------------------

Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/84#discussion_r87957495
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -543,7 +546,7 @@ protected void pRequest2Txn(int type, long zxid, Request request,
                     }
                     
                     nodeRecord = getRecordForPath(ZooDefs.CONFIG_NODE);               
    -                checkACL(zks, nodeRecord.acl, ZooDefs.Perms.WRITE, request.authInfo);
                 
    +                checkACL(zks, request.cnxn, nodeRecord.acl, ZooDefs.Perms.WRITE, request.authInfo,
"/", null);
    --- End diff --
    
    `null` tells me that the method is not expecting a value from the caller in that position,
which is better than an arbitrary value. I think it is fine to change it to `null`.


> Plumb ZooKeeperServer object into auth plugins
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-1525
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.5.0
>            Reporter: Warren Turkal
>            Assignee: Jordan Zimmerman
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch,
ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch,
ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch
>
>
> I want to plumb the ZooKeeperServer object into the auth plugins so that I can store
authentication data in zookeeper itself. With access to the ZooKeeperServer object, I also
have access to the ZKDatabase and can look up entries in the local copy of the zookeeper data.
> In order to implement this, I make sure that a ZooKeeperServer instance is passed in
to the ProviderRegistry.initialize() method. Then initialize() will try to find a constructor
for the AuthenticationProvider that takes a ZooKeeperServer instance. If the constructor is
found, it will be used. Otherwise, initialize() will look for a constructor that takes no
arguments and use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message