[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636727#comment-15636727
]
Hadoop QA commented on ZOOKEEPER-1525:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12836937/ZOOKEEPER-1525.patch
against trunk revision bcb07a09b06c91243ed244f04a71b8daf629e286.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 19 new Findbugs (version 3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of release audit
warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515//console
This message is automatically generated.
> Plumb ZooKeeperServer object into auth plugins
> ----------------------------------------------
>
> Key: ZOOKEEPER-1525
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Warren Turkal
> Assignee: Jordan Zimmerman
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch,
ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch,
ZOOKEEPER-1525.patch
>
>
> I want to plumb the ZooKeeperServer object into the auth plugins so that I can store
authentication data in zookeeper itself. With access to the ZooKeeperServer object, I also
have access to the ZKDatabase and can look up entries in the local copy of the zookeeper data.
> In order to implement this, I make sure that a ZooKeeperServer instance is passed in
to the ProviderRegistry.initialize() method. Then initialize() will try to find a constructor
for the AuthenticationProvider that takes a ZooKeeperServer instance. If the constructor is
found, it will be used. Otherwise, initialize() will look for a constructor that takes no
arguments and use that instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|