zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Zimmerman <jor...@jordanzimmerman.com>
Subject Re: committing doc changes
Date Wed, 30 Nov 2016 22:24:19 GMT
I wondered about that myself. Why bother building the docs? Isn’t that only needed for packaging/deployment?
It ends up making PRs ugly because you have all the unnecessary docs in the diff.

-Jordan

> On Nov 30, 2016, at 11:23 PM, Benjamin Reed <breed@apache.org> wrote:
> 
> when we commit pull requests with doc changes, i think we should
> commit the generated doc as a separate commit. what do you all think?
> i would like to do that to keep the change from the contributors
> pristine :) and i think it simplifies things a bit.
> 
> ben


Mime
View raw message